Redis EVAL and EVALSHA fixes and tests.#2555
Redis EVAL and EVALSHA fixes and tests.#2555unknownnf wants to merge 8 commits intofacebook:masterfrom unknownnf:patch-1
Conversation
…n be called without any arguments.
fung_get_args() always has an array with the arguments of __call like: [$fname, $args] aliased functions need only $args.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Signed. |
|
@unknownnf Thanks! I am going to put this PR up for review internally right now. |
|
I'm done with this PR for the moment since it's getting pretty big, I'll do other tests/fixes after it gets merged and I have more time. |
|
@unknownnf Oh wow, you have added more commits to this PR. I have already put this PR for review up until and including 0f6549f. Maybe the other 6 commits you have added since then can go in a separate PR? I suppose I could bring them in and squash them, but, like you said, we are already pretty big as it is. What do you think? |
Alias evaluate, evaluateSha and evalSha, rename evalSha to _evalSha for consistency. More complete tests, covering _eval and _evalSha aliases as well as script.
|
Allright, I've removed the extra commits and cleaned up the current PR, updated description. I'll prepare another PR for the other tests and fixes. |
Fixed:
__call()only$argsshould be passed as arguments.Added:
eval(),evalSha()andscript()evalandevaluateto_eval,evalShaandevaluateShato_evalShadoProcessVariantResponse()to process multibulk responses.