CMake DSO build system improvements#2610
Closed
tstarling wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Rebased on top of updated #2608. |
Applied a two-space indent. It was a mixture of 2, 3, 4 and 8 space indents and tabs; I don't know how you could look at it without going crazy. I mostly used Vim's "=" command, even in cases where its output is potentially controversial, because at least it's consistent. Also modified vertical whitespace in a couple of places. A whitespace-insensitive diff will show you where. Fixed DOS line endings in FindBISON.cmake, which were reported by git as whitespace errors.
* Use the existing macro ZEND_GET_MODULE() to provide the necessary getModule() function. * In CMake, add macro HHVM_COMPAT_EXTENSION(), equivalent to HHVM_EXTENSION(), which will register a zend-compat extension. * Set the source language, so that it's not even necessary to rename the files. This makes it trivial to have a dual-targeted source tree.
tstarling
changed the title
Contributor
Author
|
Added more DSO-related work on to this PR. |
Contributor
Author
|
The associated third-party commit hhvm/hhvm-third-party#3 should be merged after this one. |
Contributor
|
+1 |
* Install header files * Install CMake files needed by hphpize * Fix hphpize to look for headers and CMake files in the installed directory * Rename php_config.h-linux to php_config-linux.h and php_config.h-darwin to php_config-darwin.h, so that it will be picked up by *.h glob for installation. Also helps with syntax highlighting. Also: * Add an install target to the makefile of DSOs. Install to a version-dependent directory, similar to what PHP does. I chose lib/hphp over lib/hhvm for consistency with include/hphp.
Contributor
Author
|
Amended to fix missing file hphpize.in |
Contributor
|
@tstarling Hi. I pulled this in for review. I had to do some manual pulling since the patch didn't cleanly apply, even with some tweaking. Internal diff number: D1330392 |
wmfgerrit
pushed a commit
to wikimedia/mediawiki-php-luasandbox
that referenced
this pull request
May 15, 2014
Requires facebook/hhvm#2610 . Makes it possible to create a luasandbox.so with "hphpize && cmake . && make". Change-Id: I6d86adbc32fdd352b1fb0654bd246b4681465cdc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is a duplicate of #2608.
Allow dynamically loadable Zend compat extensions
Don't require full source tree for building DSOs:
Also: