Fix segfault in strtr using the Wu-Manber algorithm#6395
Closed
SiebelsTim wants to merge 1 commit intofacebook:masterfrom
Closed
Fix segfault in strtr using the Wu-Manber algorithm#6395SiebelsTim wants to merge 1 commit intofacebook:masterfrom
SiebelsTim wants to merge 1 commit intofacebook:masterfrom
Conversation
We would not take the source string length into consideration when calculating the smallest string. That would result in an unsigned integer overflow calculating the lastpos in WuManberReplacement::translate. That would later result in a segfault trying to access a char of a string beyond its size. Fixes facebook#6384 Test Plan: new test to confirm fixing the segfault. Old slow and zend tests to confirm I didn't break anything.
Contributor
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D48969 |
Contributor
Author
|
Closing in favor of #6071 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would not take the source string length into consideration when calculating
the smallest string. That would result in an unsigned integer overflow
calculating the lastpos in WuManberReplacement::translate. That would later
result in a segfault trying to access a char of a string beyond its size.
Fixes #6384
Test Plan: new test to confirm fixing the segfault. Old slow and zend tests
to confirm I didn't break anything.