Adding start transaction and commit as keywords for mysql command tracking. We happen to use different keywords for transactions than facebook does, this makes it work properly for us.#7023
Closed
joelastpass wants to merge 1 commit into
Conversation
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D57261 |
ghost
added
the
In Mysql, BEGIN is an alias for START TRANSACTION, while the latter is the standard SQL syntax, so accept that where BEGIN is also allowed. This fixes the HHVM warning: "Unable to record MySQL stats with START TRANSACTION"
joelastpass
force-pushed
the
feature_mysql_keywords
branch
from
ac465a4 to
7795a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.