[AArch64] Explicitly turn PIE off in the event that GCC has it on#8213
Open
dave-estes-QCOM wants to merge 1 commit intofacebook:masterfrom
Open
[AArch64] Explicitly turn PIE off in the event that GCC has it on#8213dave-estes-QCOM wants to merge 1 commit intofacebook:masterfrom
dave-estes-QCOM wants to merge 1 commit intofacebook:masterfrom
Conversation
…efaults to on. PIE breaks the ability to use sbrk() to reserve low memory.
Contributor
Author
|
@swalk-cavium, this is the change that I had to make to get around the issue when building on a Debian. |
ammarfaizi2
approved these changes
Nov 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some GCC toolchains are being built with PIE defaulted to on.
PIE breaks the ability to use sbrk() to reserve low memory. This
patch ensures that PIE is off regardless of how it was configured.