Configure Nix binary cache, and trigger a pull_request_target event#9092
Closed
Atry wants to merge 10 commits into
Closed
Configure Nix binary cache, and trigger a pull_request_target event#9092Atry wants to merge 10 commits into
Atry wants to merge 10 commits into
Conversation
Summary: Pull Request resolved: facebook#9090 Reviewed By: Atry Differential Revision: D36382519 fbshipit-source-id: d6c16234923477a6e03d1cec6a31430cbef49be6
Summary: This PR add Nix build files and corresponding Github Actions. - `flake.nix` is the entrypoint of the Nix build files, which references two packages: - `libdwarf.nix` is added to build `libdwarf` on both Linux and macOS, given that the `libdwarf` package in `nixpkgs-unstable` does not support macOS yet - There is a pull request to add macOS version `libdwarf` to `nixpkgs` NixOS/nixpkgs#170927 - `hhvm.nix` - This hhvm package - `shell.nix` - The non-flake entry of development environment - See https://github.com/edolstra/flake-compat about how this works - `default.nix` - The non-flake entry of this package - See https://github.com/edolstra/flake-compat about how this works Other fixes --- - Added `--assume-depexts --no-depexts` flags to `opam install`, to prevent `opam` from trying to invoke `brew install`, because all the dependencies should have been installed. Pull Request resolved: facebook#9079 Test Plan: --- See Github Actions Differential Revision: D36068249 Pulled By: Atry fbshipit-source-id: 46867bf0ebe4011b1b16809b441683a44d7f4903
Summary: This PR is on top of facebook#9079, adding the VS Code extensions and settings so that a developer can get IDE features out-of-box. How to set up the VS Code based HHVM development environment from a fresh Ubuntu: 1. Install Nix and checkout HHVM ``` sh <(curl -L https://nixos.org/nix/install) --daemon && git clone git@github.com:Atry/hhvm.git --depth 1 --recurse-submodules --branch vs-code ``` 2. Open `hhvm.code-workspace` added by this PR from VS Code 3. Install extension recommendations 4. Wait for the CMake extension to be activated 5. Click the Build button from VS Code You can also run `cmake` and other build tools from command line by using `nix-shell`. Pull Request resolved: facebook#9081 Differential Revision: D36203709 Pulled By: Atry fbshipit-source-id: 35be71fec6d6a7d2b447e00405f9336b237b261a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.