Fix crash on shutdown if log sink couldn't be created#9781
Open
mszabo-wikia wants to merge 1 commit into
Open
Conversation
Through a misconfiguration, we ended up in a situation where HHVM wasn't able to create its admin server log file. This caused a segfault on shutdown because `m_filelog` was a null pointer. Avoid crashing in this situation by not trying to close the log sink if it is `nullptr`.
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D105868587. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through a misconfiguration, we ended up in a situation where HHVM wasn't able to create its admin server log file. This caused a segfault on shutdown because
m_filelogwas a null pointer. Avoid crashing in this situation by not trying to close the log sink if it isnullptr.