Guard the elements array usage in ElementTextCache to address the memory leak#285
Merged
atootoonchianmeta merged 1 commit intofacebook:mainfrom Feb 11, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Using memlab, we identified that a significant memory leak is coming from ElementTextCache as it's holding the detached DOM elements. Below is the memory trace
Problem
The ElementTextCache is a WeakMap that caches element text extraction results:
However, the cached value contains strong references that prevent garbage collection:
The
finalResult.elementText.elementsarray accumulates all DOM elements that contributed text (see lines 1010):The elements array accumulated all DOM elements that contributed text to the cached result. When an element was removed from the DOM.
Fix
This diff fixes a memory leak by guarding the
elementsarray which contains the DOM element references from cached text objects. WhenexcludeElementsFromCacheoption is enabled, it creates leaner cache entries containing only text and source properties instead of also storing element references.