Skip to content

fix: resolve #390 — Docs are not helpful#706

Open
ed-thuando wants to merge 1 commit intofacebook:mainfrom
ed-thuando:contribai/docs/find-and-examine-the-closest-method-impl
Open

fix: resolve #390 — Docs are not helpful#706
ed-thuando wants to merge 1 commit intofacebook:mainfrom
ed-thuando:contribai/docs/find-and-examine-the-closest-method-impl

Conversation

@ed-thuando
Copy link
Copy Markdown

Summary

fix: resolve #390 — Docs are not helpful

Problem

Severity: Medium | File: src/Collection.js

The Collection.js file contains the base Collection class with the core methods. I need to find the closest method implementation to understand its parameters and behavior so I can document it correctly.

Solution

Look for the closest method definition in Collection.js. The method likely takes a type parameter (likely a string or AST node type) and a filter function. Based on common AST traversal patterns, closest probably traverses up the AST to find the nearest ancestor matching the given type.

Changes

  • src/collections/Node.js (modified)

Testing

  • Existing tests pass
  • Manual review completed
  • No new warnings/errors introduced

Generated by ContribAI v6.0.0

Fixes facebook#390

Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 11, 2026

@ed-thuando is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 11, 2026

⚠️ No Changeset found

Latest commit: 979e323

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 11, 2026

Hi @ed-thuando!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Daniel15
Copy link
Copy Markdown
Member

Looks good. Please complete the CLA so I can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs are not helpful

2 participants