Skip to content

Misc step recorder fixes and improvements#100

Merged
feedthejim merged 4 commits into
mainfrom
step-recorder-fixes
Feb 17, 2021
Merged

Misc step recorder fixes and improvements#100
feedthejim merged 4 commits into
mainfrom
step-recorder-fixes

Conversation

@feedthejim

Copy link
Copy Markdown

this PR adds:

  • ctrl/cmd + K record toggling shortcuts
  • refactor the event handlnig to be a bit less ugly
  • fixes an issue with the placeholder test template
  • stop listening for selection changes when using the left/right keys

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2021
@feedthejim feedthejim merged commit 4cc2fa2 into main Feb 17, 2021
@feedthejim feedthejim deleted the step-recorder-fixes branch February 17, 2021 15:49
acywatson pushed a commit that referenced this pull request Apr 9, 2022
* step recorder: add manually dir to test template

* step recorder: add ctrl/cmd+k shortcut

* step recorder: clean up the input checker logic

* step-recorder: replace left/right commands to native ones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants