Remove unused ref in Playground ToolbarPlugin#2133
Merged
Conversation
This PR cleans up the Toolbar from the playground removing a seemingly useless ref that's never set
hanford
requested review from
acywatson,
fantactuka,
thegreatercurve,
trueadm,
tylerjbainbridge and
zurfyx
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hanford
changed the title
trueadm
approved these changes
May 11, 2022
trueadm
left a comment
trueadm
left a comment
Collaborator
There was a problem hiding this comment.
Nice one! This was probably missed in a refactor.
Contributor
Author
|
Anything needed on my end to get the build ✅ ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the Toolbar from the Playground, removing a ref that's never set.
Feel free to close this, if
mouseDownRefis needed, but on master it's never actually used which caused me some confusion as I was replicating the Toolbar