Skip to content

Add list plugin example#3324

Merged
thegreatercurve merged 28 commits into
facebook:mainfrom
akmarzhan1:inline
Nov 8, 2022
Merged

Add list plugin example#3324
thegreatercurve merged 28 commits into
facebook:mainfrom
akmarzhan1:inline

Conversation

@akmarzhan1

@akmarzhan1 akmarzhan1 commented Nov 5, 2022

Copy link
Copy Markdown
Contributor
  • created a CodeSandbox example for the list plugin here
  • added a new page and the example on the website (under “/docs/demos/plugins/lists”)

image

Issue #2886

@vercel

vercel Bot commented Nov 5, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 0:01AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 0:01AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2022
@akmarzhan1

akmarzhan1 commented Nov 5, 2022

Copy link
Copy Markdown
Contributor Author

I have only added the bullet list and numbered list because there were some issues with the checklist (although I imported all of the necessary components, checklists were showing up as bullet lists) and I wasn't sure whether I needed to add the examples from the list plugin only or also from the checklist plugin.

I think I also accidentally set the last PR (mentions example) to get merged to facebook:inline branch instead of the main, which is why now it is showing the previous commits.

Let me know if I need to fix anything.

@akmarzhan1 akmarzhan1 changed the base branch from inline to main November 5, 2022 02:41
@akmarzhan1 akmarzhan1 marked this pull request as ready for review November 5, 2022 02:43
@akmarzhan1 akmarzhan1 requested a review from trueadm as a code owner November 5, 2022 02:43
@fantactuka

Copy link
Copy Markdown
Collaborator

I have only added the bullet list and numbered list because there were some issues with the checklist (although I imported all of the necessary components, checklists were showing up as bullet lists) and I wasn't sure whether I needed to add the examples from the list plugin only or also from the checklist plugin.

Checklist requires some css to render "checkbox"

@acywatson acywatson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the package-lock change - did you add a new package?

@akmarzhan1

Copy link
Copy Markdown
Contributor Author

Not sure about the package-lock change - did you add a new package?

Also not sure where the changes came from since I didn't add new packages. Should I revert those differences?

@akmarzhan1

Copy link
Copy Markdown
Contributor Author

some css

That makes sense! I totally missed these, will add and update

@akmarzhan1

akmarzhan1 commented Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

@fantactuka added the check list css and now it works:

image

@acywatson reverted the package-lock changes.

Let me know if I need to fix anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants