Filter out mixed files + content copy pasting#3329
Merged
Conversation
fantactuka
requested review from
acywatson,
thegreatercurve,
trueadm,
tylerjbainbridge and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
fantactuka
commented
Nov 8, 2022
| const types = dataTransfer.types; | ||
| const hasFiles = types.includes('Files'); | ||
| const hasContent = | ||
| types.includes('text/html') || types.includes('text/plain'); |
Collaborator
Author
There was a problem hiding this comment.
@zurfyx Not sure which check is better: text/html | plain/text or just check if there's anything else except 'Files'
Member
There was a problem hiding this comment.
I'd say what you have now is best as many apps including Mac Finder tend to include a variety of formats
thegreatercurve
approved these changes
Nov 8, 2022
zurfyx
approved these changes
Nov 8, 2022
| const types = dataTransfer.types; | ||
| const hasFiles = types.includes('Files'); | ||
| const hasContent = | ||
| types.includes('text/html') || types.includes('text/plain'); |
Member
There was a problem hiding this comment.
I'd say what you have now is best as many apps including Mac Finder tend to include a variety of formats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When copying, MSWord adds content as an image to the clipboard (apart from various text formats data), and our file copy/pasting logic which is executed before text content parsing inserts that image instead of actual text content:
Screen.Recording.2022-11-07.at.10.28.00.PM.mov