Deprecate editor.currentTextContent#789
Merged
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
zurfyx
force-pushed
the
drop-currentextcontent
branch
from
a3542f1 to
83290dc
Compare
zurfyx
force-pushed
the
drop-currentextcontent
branch
from
83290dc to
01a797b
Compare
trueadm
approved these changes
Nov 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #784 we moved the precomputed text content to live inside RootNode and we introduced a trigger to listen to text changes. We can now kill the
editor.currentTextContentwhich is misleading.This PR doesn't kill it entirely, I'll iterate on this to move the other methods that depend on this and WWW may need some time before we can actually get rid of it for good.