[lexical-table] Bug Fix: Prevent single-cell table selection after exiting table selection#8195
Merged
etrepum merged 3 commits intofacebook:mainfrom Mar 9, 2026
Conversation
randal-atticus
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
randal-atticus
commented
Mar 6, 2026
| focusCell !== tableObserver.anchorCell && | ||
| tableObserver.anchorCell !== null && | ||
| tableObserver.anchorCellNodeKey !== null && | ||
| focusCell.elem !== tableObserver.anchorCell.elem && |
Contributor
Author
There was a problem hiding this comment.
also had to change this because even when they were the same cell, they were not referentially equal
etrepum
previously approved these changes
Mar 6, 2026
Collaborator
etrepum
left a comment
etrepum
left a comment
There was a problem hiding this comment.
Approved assuming tests are passing
etrepum
dismissed
their stale review
Looks like there might be some kind of issue with collab here
Collaborator
|
Looks like there's some sort of conflict with collab in this PR that needs further investigation |
Contributor
Author
|
Seems to have just been an issue in one test, even though other tests failed. Fixed. |
etrepum
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug introduced in #8193, I think. We were not calling $clearHighlight of a table when clicking on it, meaning it stayed in "highlight mode". This made the table selection mode feel sticky, because any subsequent pointerMove events (which are very eager to fire) would highlight the entire cell. The only way to exit the mode was to very precisely click without moving the mouse.
Test plan
Before
Screen.Recording.2026-03-06.at.9.00.56.pm.mov
After
Screen.Recording.2026-03-06.at.9.01.12.pm.mov