[lexical-table][lexical-playground] Breaking change: Move hasFitNestedTables logic to Playground plugin#8210
Merged
etrepum merged 2 commits intofacebook:mainfrom Mar 15, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change
The
hasFitNestedTablesoption in TablePlugin introduced in v0.41.0 (#8097) has been moved to an independent playground plugin due to edge cases and its experimental state.Description
The recently implemented
hasFitNestedTablesin #8097 works in the general case (i.e. in Playground) however after attempting to use it as-is in our application I discovered some application-specific edge cases or gaps, such as:markDirtyworks to force the MutationListener to run but is a hack, but what I really wanted to do was to explicitly re-run the resizing logic, which I couldn't do.With the gaps listed above, and how new this feature is (I bet no one else is using it), I think it's a good time to cut losses and move the plugin to Playground. However,
TableNode.scaleDOMColWidthscan/should stay in lexical-table.Test plan
Before
N/A
After
Feature still works as expected (there is also an E2E test checking
hasFitNestedTablesand is unchanged in this PR)Screen.Recording.2026-03-11.at.9.36.31.pm.mov