[lexical-playground] Fix: use inline style for LayoutContainerNode import#8214
Conversation
…tContainerNode import $convertLayoutContainerElement used window.getComputedStyle() which returns empty values for unmounted DOM nodes during HTML import. Since exportDOM() writes gridTemplateColumns as an inline style, read it directly via domNode.style.gridTemplateColumns instead. Fixes facebook#6813 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WhyBusyy
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hi @WhyBusyy! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
I’ll review after the CLA is signed and this PR has tests that demonstrate that the change works as expected |
|
@etrepum Already signed! Thanks for the quick review! |
…export Verify that LayoutContainerNode correctly reads gridTemplateColumns from inline style during DOM import, covering export, import, and round-trip scenarios.
meta-cla
bot
added
the
CLA Signed
etrepum
changed the title
2 participants
Summary
$convertLayoutContainerElementusedwindow.getComputedStyle()which returns empty values for unmounted DOM nodes during HTML importexportDOM()storesgridTemplateColumnsas an inline style, read it directly viadomNode.style.gridTemplateColumnsFixes #6813
Test plan
$generateHtmlFromNodes)$generateNodesFromDOM)🤖 Generated with Claude Code