Skip to content

[lexical-table] Chore: add test for mouse leaving browser window during table selection#8215

Merged
etrepum merged 1 commit intofacebook:mainfrom
takenosuke-code:fix/table-mouse-leave-test
Mar 12, 2026
Merged

[lexical-table] Chore: add test for mouse leaving browser window during table selection#8215
etrepum merged 1 commit intofacebook:mainfrom
takenosuke-code:fix/table-mouse-leave-test

Conversation

@takenosuke-code
Copy link
Contributor

Summary

Adds a unit test that verifies table selection is properly cleaned up when the mouse leaves the browser window during a drag operation and re-enters with buttons=0 (button state lost).

Also fixes the PointerEvent test polyfill to use nullish coalescing (??) instead of OR (||) so buttons: 0 can be passed correctly.

Closes #5928

Test Plan

  • pnpm run test-unit packages/lexical-table/src/__tests__/unit/LexicalTableMobileSelection.test.tsx - all 6 tests pass

@vercel
Copy link

vercel bot commented Mar 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lexical Ready Ready Preview, Comment Mar 12, 2026 9:18am
lexical-playground Ready Ready Preview, Comment Mar 12, 2026 9:18am

Request Review

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2026
@etrepum etrepum changed the title test(lexical-table): add test for mouse leaving browser window during table selection [lexical-table] Chore: add test for mouse leaving browser window during table selection Mar 12, 2026
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Mar 12, 2026
@etrepum etrepum added this pull request to the merge queue Mar 12, 2026
Merged via the queue into facebook:main with commit b2b7f44 Mar 12, 2026
38 checks passed
@etrepum etrepum mentioned this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TODO: Add a test for mouse leaving browser window during table selection

2 participants