[lexical-devtools-core] Bug Fix: Clean up strict mode useLexicalCommandsLog behavior#8230
Merged
etrepum merged 1 commit intofacebook:mainfrom Mar 17, 2026
Merged
Conversation
etrepum
requested review from
acywatson,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
etrepum
commented
Mar 17, 2026
| payload, | ||
| type: command.type ? command.type : 'UNKNOWN', | ||
| }; | ||
| setLoggedCommands((state) => [...state.slice(-9), entry]); |
Collaborator
Author
There was a problem hiding this comment.
This is the actual fix, the rest of the PR is just cleanup
zurfyx
approved these changes
Mar 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
useLexicalCommandLogindexes would skip entries when run in dev (React strict mode) because setState callbacks are called twice. The callback had observable side-effects.Test plan
Before
Run
pnpm devand observe the command log indices missing numbers in the series (e.g. 1, 3, 5, 7)After
Run
pnpm devand observe that the command log indices are now dense (e.g. 1, 2, 3, 4)