Skip to content

[lexical-playground][lexical-react] Bug Fix: Fix accessor implementations to use getLatest/getWritable consistently#8241

Merged
etrepum merged 1 commit intofacebook:mainfrom
etrepum:fix-getters-and-setters
Mar 19, 2026
Merged

[lexical-playground][lexical-react] Bug Fix: Fix accessor implementations to use getLatest/getWritable consistently#8241
etrepum merged 1 commit intofacebook:mainfrom
etrepum:fix-getters-and-setters

Conversation

@etrepum
Copy link
Collaborator

@etrepum etrepum commented Mar 19, 2026

Description

Fixes accessors of playground node classes and DecoratorBlockNode to consistently use getLatest/getWritable and return the instance from setters.

Used Claude to do most of this but reviewed the output

Test plan

All existing tests pass

…ions to use getLatest/getWritable consistently
@vercel
Copy link

vercel bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lexical Ready Ready Preview, Comment Mar 19, 2026 7:11pm
lexical-playground Ready Ready Preview, Comment Mar 19, 2026 7:11pm

Request Review

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2026
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Mar 19, 2026
@etrepum etrepum marked this pull request as ready for review March 19, 2026 19:32
@etrepum etrepum added this pull request to the merge queue Mar 19, 2026
Merged via the queue into facebook:main with commit d04cf6a Mar 19, 2026
41 of 67 checks passed
@etrepum etrepum deleted the fix-getters-and-setters branch March 19, 2026 20:08
@etrepum etrepum mentioned this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants