[*] Chore: Update flow-bin to 0.306.0 and add incompatible-variance workaround#8253
Merged
etrepum merged 2 commits intofacebook:mainfrom Mar 23, 2026
Merged
[*] Chore: Update flow-bin to 0.306.0 and add incompatible-variance workaround#8253etrepum merged 2 commits intofacebook:mainfrom
etrepum merged 2 commits intofacebook:mainfrom
Conversation
…rom, resetOnCopyNodeFrom
etrepum
requested review from
acywatson,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
ivailop7
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates flow-bin and configures .flowconfig for 0.306.0 and adds a workaround for the incompatible-variance violation in the signatures for
afterCloneFromandresetOnCopyNodeFrom. TypeScript allows the unsound usage ofthisas a parameter, which matches the intent of the argument in these functions, but Flow does not… so we do something even more unsound as a workaround.Note that this same unsound variance usage happens in
updateDOM, so we use the same workaround here. If a better workaround is found, all three signatures should be addressed.Closes #8252
Test plan
pnpx flow-bin checkorpnpm run flowshould succeed