[lexical-code-shiki] Chore: Upgrade shiki to ^4.0.2#8330
Merged
etrepum merged 3 commits intofacebook:mainfrom Apr 11, 2026
Merged
[lexical-code-shiki] Chore: Upgrade shiki to ^4.0.2#8330etrepum merged 3 commits intofacebook:mainfrom
etrepum merged 3 commits intofacebook:mainfrom
Conversation
Bumps shiki and all @shikijs/* packages from ^3.7.0 to ^4.0.2 (latest). The only breaking changes in v4.0.0 are dropping Node v18 support (we already require Node >=20.19.0) and renaming internal APIs (ShikiInternal -> ShikiPrimitive, createdBundledHighlighter -> createBundledHighlighter). None of the APIs used by @lexical/code-shiki are affected: createHighlighterCoreSync, codeToTokens (highlighter method), loadLanguage, loadTheme, isSpecialLang, isSpecialTheme, getTokenStyleObject, stringifyTokenStyle, bundledLanguagesInfo, bundledThemesInfo, and ThemedToken/TokensResult types all remain stable. Also bumps the root pnpm override for @shikijs/types from 3.20.0 to 4.0.2 so the whole workspace resolves consistently. https://claude.ai/code/session_01AjBVBzGNkvmJgGuAc9kePB
The @shikijs/types override was added when the workspace used @shikijs/*@3.x, where loose semver ranges on @shikijs/types produced duplicate resolutions and the override was needed to deduplicate them. With @shikijs/*@4.0.2, every shiki package pins @shikijs/types to an exact version, so the @lexical/code-shiki dependency tree already deduplicates on its own. The only remaining consumers of @shikijs/types in this workspace are the 3.x packages pulled transitively by typedoc via @gerrit0/mini-shiki, which are isolated to docs generation and never cross the lexical-code-shiki boundary. Forcing those 3.x packages to use 4.x types is also semantically incorrect since they were published against 3.x type shapes. Verified that tsc, flow, prettier, lint, unit tests, and `pnpm run build-docs` (which exercises the mini-shiki typedoc path) all still succeed without the override. https://claude.ai/code/session_01AjBVBzGNkvmJgGuAc9kePB
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
requested review from
acywatson,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
ivailop7
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps shiki and all @shikijs/* packages from ^3.7.0 to ^4.0.2 (latest). The only breaking changes in v4.0.0 are dropping Node v18 support (we already require Node >=20.19.0) and renaming internal APIs (ShikiInternal -> ShikiPrimitive, createdBundledHighlighter -> createBundledHighlighter). None of the APIs used by @lexical/code-shiki are affected: createHighlighterCoreSync, codeToTokens (highlighter method), loadLanguage, loadTheme, isSpecialLang, isSpecialTheme, getTokenStyleObject, stringifyTokenStyle, bundledLanguagesInfo, bundledThemesInfo, and ThemedToken/TokensResult types all remain stable.
Test plan
No expected changes, all tests should pass as-is