[lexical-markdown] Bug Fix: replace lookbehind assertions for Safari < 16.4 compatibility#8332
Merged
etrepum merged 1 commit intofacebook:mainfrom Apr 11, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current behavior: Negative lookbehind assertions (
(?<!...)) insidecreateTextFormatTransformersIndexthrow aSyntaxErroratnew RegExp(...)construction time in Safari < 16.4 (ES2018 not supported), crashing markdown
import entirely for those users.
Changes: Replace all lookbehind-based patterns with a preceding-character
capture group
(^|[^\\...])that matches start-of-string or a non-escapecharacter before the delimiter. Call sites offset
match.indexbymatch[1].lengthto find the real start of the span. The escape guard onopenTagsRegExpis removed sinceisEscaped()inscanDelimiters()alreadyhandles this.
Closes #8012
Test plan
Before
Safari < 16.4 throws
SyntaxError: Invalid regular expression: invalid group specifier namewhen any markdown string is imported — no markdown renderingworks at all.
After
7 new unit tests added to
LexicalMarkdown.test.ts:All 2,754 existing tests continue to pass.