Skip to content

[lexical] Bug Fix: Resolve Firefox arrow key navigation issue in collapsible nodes (#8348)#8349

Merged
etrepum merged 3 commits intofacebook:mainfrom
MohmedIkram:fix-firefox-collapsible-8348
Apr 14, 2026
Merged

[lexical] Bug Fix: Resolve Firefox arrow key navigation issue in collapsible nodes (#8348)#8349
etrepum merged 3 commits intofacebook:mainfrom
MohmedIkram:fix-firefox-collapsible-8348

Conversation

@MohmedIkram
Copy link
Copy Markdown
Contributor

Description

This PR fixes a Firefox-specific issue where arrow key navigation skips over collapsible content inside <details> elements.

Current Behavior

  • In Firefox, pressing the down arrow from the collapsible title (<summary>) skips the content inside the collapsible.
  • Similarly, arrow up from the next paragraph skips the entire collapsible block.
  • This results in inconsistent navigation compared to Chrome and Safari.

Changes Made

  • Implemented a fix to ensure arrow key navigation correctly moves between blocks inside collapsible nodes in Firefox.
  • Added handling to prevent skipping of collapsible content during keyboard navigation.

Result

  • Arrow key navigation now behaves consistently across browsers.
  • Users can navigate into and out of collapsible content as expected.

Before

Screen.Recording.2026-04-12.at.1.41.54.PM.mov

After

Screen.Recording.2026-04-12.at.1.42.28.PM.mov

Closes #8348

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lexical Ready Ready Preview, Comment Apr 14, 2026 4:44pm
lexical-playground Ready Ready Preview, Comment Apr 14, 2026 4:44pm

Request Review

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 12, 2026

Hi @MohmedIkram!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 12, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Apr 12, 2026
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important to make sure that this behavior is tested. I don't see any changes to the relevant e2e tests, which will probably be in a failing state, but there should also be new test code to ensure the up and down arrows work as expected in all browsers with this node.

@etrepum etrepum added this pull request to the merge queue Apr 14, 2026
Merged via the queue into facebook:main with commit 1e17a63 Apr 14, 2026
34 checks passed
@etrepum etrepum mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Firefox regression in up/down arrow key handling with collapsible

2 participants