[lexical] Bug Fix: Resolve Firefox arrow key navigation issue in collapsible nodes (#8348)#8349
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hi @MohmedIkram! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
etrepum
left a comment
There was a problem hiding this comment.
It's important to make sure that this behavior is tested. I don't see any changes to the relevant e2e tests, which will probably be in a failing state, but there should also be new test code to ensure the up and down arrows work as expected in all browsers with this node.
2bb71a1 to
380e51f
Compare
Description
This PR fixes a Firefox-specific issue where arrow key navigation skips over collapsible content inside
<details>elements.Current Behavior
<summary>) skips the content inside the collapsible.Changes Made
Result
Before
Screen.Recording.2026-04-12.at.1.41.54.PM.mov
After
Screen.Recording.2026-04-12.at.1.42.28.PM.mov
Closes #8348