[Breaking Change][lexical-offset][lexical] Chore: Deprecate the broken/undocumented/untested OffsetView and export $createChildrenArray from lexical#8350
Merged
etrepum merged 3 commits intofacebook:mainfrom Apr 12, 2026
Conversation
…n/undocumented/untested OffsetView and export $createChildrenArray from lexical
etrepum
requested review from
acywatson,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
ivailop7
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OffsetView/$createOffsetViewnever worked correctly, doesn't have documentation, doesn't have tests, and has no usage anywhere else in the lexical monorepo. This deprecates it and moves the only used function$createChildrenArray(which is a copy of an internal lexical function) to a re-export of the functionality from the lexical module.There is certainly a use case for something like OffsetView but there's no reason to believe that trying to fix it in situ is any better than starting over from first principles.
Closes #8312
Closes #7580
Test plan
Existing test suite coverage of collab's usage of
$createChildrenArray