[lexical-react] Bug Fix: Add 'yjs' as optional peer dependency for Yarn PnP compatibility#8366
Conversation
…rn PnP compatibility Co-authored-by: 김종현 <97939463+flex-jonghyen@users.noreply.github.com> Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Hi @grapgrap! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
etrepum
left a comment
There was a problem hiding this comment.
CI is going to fail until pnpm-lock is updated accordingly
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Description
Re-submission of #8053 (closed due to unsigned CLA).
@flex-jonghyen is my own work account, but I'm unable to sign the CLA under it — so I'm re-opening this from my personal account.
Current problem:
@lexical/reactincludes@lexical/yjsas a dependency@lexical/yjsrequiresyjsas a peer dependency (>=13.5.22)yjsis not declared in@lexical/reactyjsChanges:
yjsas an optional peer dependency in@lexical/react(version range matches@lexical/yjs:>=13.5.22)Test plan
Before
Yarn PnP environment fails to resolve
yjs.Workaround required in
.yarnrc.yml:This workaround confirms that adding
yjsas a peer dependency resolves the issue.After
Works without the workaround.