[lexical-website] Bug Fix: Fix type checking for lexical-website package#8371
Merged
etrepum merged 1 commit intofacebook:mainfrom Apr 19, 2026
Merged
Conversation
…e sources in CI The root tsconfig.json excludes packages/lexical-website/** so neither pnpm run tsc nor pnpm run build-docs surfaced TypeScript errors there. Add a dedicated tsconfig.json that pulls in docusaurus.config.ts, the plugins/, src/, and libdefs, wire it into a new tsc-website script, and run it as part of ci-check and the website build. Fixes latent type errors in docusaurus.config.ts (sidebar grouping predicate, webpack resolve.alias typing, plugin module typing) and the package-docs plugin JSDoc. https://claude.ai/code/session_015YiPnjXbo4Pehqi69PJbyc
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
requested review from
acywatson,
fantactuka,
potatowagon,
takuyakanbr and
zurfyx
as code owners
zurfyx
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The root tsconfig.json excludes packages/lexical-website/** so neither pnpm run tsc nor pnpm run build-docs surfaced TypeScript errors there. Add a dedicated tsconfig.json that pulls in docusaurus.config.ts, the plugins/, src/, and libdefs, wire it into a new tsc-website script, and run it as part of ci-check and the website build. Fixes latent type errors in docusaurus.config.ts (sidebar grouping predicate, webpack resolve.alias typing, plugin module typing) and the package-docs plugin JSDoc.
Follow-up to #8369
Closes #8370
Test plan
Before
Types not checked
After
Types checked