[lexical-link][lexical-react] Feature: Allow custom punctuation for AutoLink boundaries by holly-agyei · Pull Request #8378 · facebook/lexical

holly-agyei · 2026-04-20T19:50:01Z

Summary

add an optional punctuation setting to AutoLinkExtension and registerAutoLink
thread that option through AutoLinkPlugin while preserving the existing default separators
add coverage for colon-delimited custom matches and ensure URLs with embedded colons still autolink correctly
sync the published Flow declarations and React plugin docs with the new config

Test plan

./node_modules/.bin/vitest --project unit --run packages/lexical-link/src/tests/unit/LexicalAutoLinkExtension.test.ts
./node_modules/.bin/eslint --no-warn-ignored packages/lexical-link/src/LexicalAutoLinkExtension.ts packages/lexical-link/src/tests/unit/LexicalAutoLinkExtension.test.ts packages/lexical-react/src/LexicalAutoLinkPlugin.ts
./node_modules/.bin/tsc -p tsconfig.json --noEmit

vercel · 2026-04-20T19:50:06Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lexical	Ready	Preview, Comment	Apr 24, 2026 1:07am
lexical-playground	Ready	Preview, Comment	Apr 24, 2026 1:07am

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a configurable punctuation boundary set for AutoLink matching so custom matchers can treat additional separators (e.g., :) as boundaries without breaking URL autolinking (including embedded colons).

Changes:

Thread a new optional punctuation option through registerAutoLink and the React AutoLinkPlugin.
Add unit tests covering colon-delimited matches and port URLs containing colons.
Update Flow declarations and React plugin docs to reflect the new option.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/lexical-website/docs/react/plugins.md	Documents the new `punctuation` prop for `AutoLinkPlugin`.
packages/lexical-react/src/LexicalAutoLinkPlugin.ts	Adds `punctuation` prop and passes it through to `registerAutoLink`.
packages/lexical-react/flow/LexicalAutoLinkPlugin.js.flow	Updates Flow typings for `AutoLinkPlugin` props (including `punctuation`).
packages/lexical-link/src/LexicalAutoLinkExtension.ts	Implements punctuation-driven boundary detection and threads config through core logic.
packages/lexical-link/src/tests/unit/LexicalAutoLinkExtension.test.ts	Adds coverage for default/custom punctuation behavior and embedded-colon URLs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

etrepum

pnpm run ci-check is failing

…punctuation for AutoLink boundaries

etrepum · 2026-04-22T03:59:43Z

Sign in to view

 export type AutoLinkConfig = {
-  matchers: LinkMatcher[];
  changeHandlers: ChangeHandler[];
+  excludeParents: Array<(parent: ElementNode) => boolean>;


Suggested change

excludeParents: Array<(parent: ElementNode) => boolean>;

excludeParents: ((parent: ElementNode) => boolean)[];

etrepum · 2026-04-22T03:59:57Z

Sign in to view

  changeHandlers: ChangeHandler[];
+  excludeParents: Array<(parent: ElementNode) => boolean>;
+  matchers: LinkMatcher[];
+  separatorRegex?: RegExp;


Suggested change

separatorRegex?: RegExp;

separatorRegex: RegExp;

etrepum · 2026-04-22T04:10:23Z

Sign in to view

 export interface AutoLinkConfig {
-  matchers: LinkMatcher[];
  changeHandlers: ChangeHandler[];
  excludeParents: Array<(parent: ElementNode) => boolean>;


Suggested change

excludeParents: Array<(parent: ElementNode) => boolean>;

excludeParents: ((parent: ElementNode) => boolean)[];

etrepum · 2026-04-22T04:11:10Z

Sign in to view

+   * characters count as separators when validating auto-link
+   * boundaries. Defaults to `/[.,;\s]/`.
+   */
+  separatorRegex?: RegExp;


Configuration of extensions should always use required properties unless undefined is specifically a value that is useful to the extension.

Suggested change

separatorRegex?: RegExp;

separatorRegex: RegExp;

etrepum · 2026-04-22T04:13:49Z

Sign in to view


 export function registerAutoLink(
  editor: LexicalEditor,
  config: AutoLinkConfig = defaultConfig,


This type will have to change accordingly to something like Partial<AutoLinkConfig> (which would require some implementation changes below to provide defaults for each value) or Partial<AutoLinkConfig> & Omit<AutoLinkConfig, 'separatorRegex'>

Suggested change

config: AutoLinkConfig = defaultConfig,

config: Partial<AutoLinkConfig> & Omit<AutoLinkConfig, 'separatorRegex'> = defaultConfig,

etrepum · 2026-04-22T04:14:31Z

 export type {ChangeHandler, LinkMatcher};

 declare export function AutoLinkPlugin(props: {
+  excludeParents?: Array<(parent: ElementNode) => boolean>,


Suggested change

excludeParents?: Array<(parent: ElementNode) => boolean>,

excludeParents?: ((parent: ElementNode) => boolean)[],

etrepum · 2026-04-22T04:15:09Z


 declare export function AutoLinkPlugin(props: {
+  excludeParents?: Array<(parent: ElementNode) => boolean>,
  matchers: Array<LinkMatcher>,


Suggested change

matchers: Array<LinkMatcher>,

matchers: LinkMatcher[],

holly-agyei · 2026-04-22T22:41:11Z

@etrepum I've pushed the updates to address your feedback regarding the Flow array syntax and the AutoLinkConfig properties. Could you please take another look when you have a chance?

etrepum

It doesn't look like you addressed any of the last round of suggestions?

Sign in to view

 export type AutoLinkConfig = {
-  matchers: LinkMatcher[];
  changeHandlers: ChangeHandler[];
+  excludeParents: Array<(parent: ElementNode) => boolean>;


Sign in to view

  changeHandlers: ChangeHandler[];
+  excludeParents: Array<(parent: ElementNode) => boolean>;
+  matchers: LinkMatcher[];
+  separatorRegex?: RegExp;


Sign in to view

 export interface AutoLinkConfig {
-  matchers: LinkMatcher[];
  changeHandlers: ChangeHandler[];
  excludeParents: Array<(parent: ElementNode) => boolean>;


Sign in to view

+   * characters count as separators when validating auto-link
+   * boundaries. Defaults to `/[.,;\s]/`.
+   */
+  separatorRegex?: RegExp;


Sign in to view


 export function registerAutoLink(
  editor: LexicalEditor,
  config: AutoLinkConfig = defaultConfig,


Copilot AI review requested due to automatic review settings April 20, 2026 19:50

holly-agyei requested review from acywatson, etrepum, fantactuka, ivailop7, potatowagon, takuyakanbr and zurfyx as code owners April 20, 2026 19:50

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 20, 2026

vercel Bot deployed to Preview – lexical-playground April 20, 2026 19:51 View deployment

vercel Bot deployed to Preview – lexical April 20, 2026 19:51 View deployment

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread packages/lexical-website/docs/react/plugins.md Outdated

Comment thread packages/lexical-link/src/LexicalAutoLinkExtension.ts Outdated

Copilot started reviewing on behalf of holly-agyei April 20, 2026 20:17 View session

etrepum reviewed Apr 21, 2026

View reviewed changes

holly-agyei added 2 commits April 21, 2026 00:07

[lexical-link][lexical-react][lexical-website] Feature: Allow custom …

a74dac0

…punctuation for AutoLink boundaries

[lexical-link] Chore: format auto-link extension

c33950e

holly-agyei force-pushed the feat-8189-autolink-custom-punctuation branch from ab76069 to c33950e Compare April 21, 2026 05:22

vercel Bot deployed to Preview – lexical-playground April 21, 2026 05:24 View deployment

vercel Bot deployed to Preview – lexical April 21, 2026 05:24 View deployment

etrepum added the extended-tests Run extended e2e tests on a PR label Apr 21, 2026

etrepum reviewed Apr 21, 2026

View reviewed changes

Comment thread packages/lexical-link/src/LexicalAutoLinkExtension.ts Outdated

Improve AutoLink separator matching performance

6b4751f

vercel Bot deployed to Preview – lexical-playground April 21, 2026 17:51 View deployment

vercel Bot deployed to Preview – lexical April 21, 2026 17:51 View deployment

Format AutoLink separator regex changes

02a9704

vercel Bot deployed to Preview – lexical-playground April 21, 2026 18:05 View deployment

vercel Bot deployed to Preview – lexical April 21, 2026 18:05 View deployment

etrepum reviewed Apr 21, 2026

View reviewed changes

Comment thread packages/lexical-link/src/LexicalAutoLinkExtension.ts Outdated

Align AutoLink separator API with review

5f6c0ef

vercel Bot deployed to Preview – lexical-playground April 21, 2026 18:18 View deployment

vercel Bot deployed to Preview – lexical April 21, 2026 18:19 View deployment

etrepum reviewed Apr 22, 2026

View reviewed changes

Use shorthand Flow array syntax

16b9e54

vercel Bot deployed to Preview – lexical-playground April 22, 2026 07:34 View deployment

vercel Bot deployed to Preview – lexical April 22, 2026 07:34 View deployment

etrepum reviewed Apr 22, 2026

View reviewed changes

[lexical-link] Address AutoLinkConfig review feedback

6f17b08

vercel Bot deployed to Preview – lexical-playground April 23, 2026 18:58 View deployment

vercel Bot deployed to Preview – lexical April 23, 2026 18:59 View deployment

Merge branch 'main' into feat-8189-autolink-custom-punctuation

1472476

vercel Bot deployed to Preview – lexical-playground April 24, 2026 01:06 View deployment

vercel Bot deployed to Preview – lexical April 24, 2026 01:07 View deployment

etrepum approved these changes Apr 24, 2026

View reviewed changes

etrepum added this pull request to the merge queue Apr 24, 2026

Merged via the queue into facebook:main with commit a6081bb Apr 24, 2026
41 checks passed

etrepum mentioned this pull request Apr 27, 2026

v0.44.0 #8394

Merged

	excludeParents: Array<(parent: ElementNode) => boolean>;
	excludeParents: ((parent: ElementNode) => boolean)[];

	config: AutoLinkConfig = defaultConfig,
	config: Partial<AutoLinkConfig> & Omit<AutoLinkConfig, 'separatorRegex'> = defaultConfig,

	excludeParents?: Array<(parent: ElementNode) => boolean>,
	excludeParents?: ((parent: ElementNode) => boolean)[],

Conversation

holly-agyei commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

vercel Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

etrepum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

etrepum Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

etrepum Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

etrepum Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

etrepum Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

etrepum Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

etrepum Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

etrepum Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

holly-agyei commented Apr 22, 2026

Uh oh!

etrepum left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

holly-agyei commented Apr 20, 2026 •

edited

Loading

vercel Bot commented Apr 20, 2026 •

edited

Loading