[examples] Chore: Disable skipLibCheck in react-rich for lib-types regression coverage (#7093)#8473
Merged
etrepum merged 1 commit intoMay 7, 2026
Conversation
…overage Closes facebook#7093. Configures examples/react-rich with skipLibCheck: false so the example's `tsc && vite build` step (already exercised by the prepare-release integration tests in scripts/__tests__/integration/) acts as a regression check on the published Lexical packages' .d.ts surface against React 19 + TypeScript 5.9. react-rich was picked because it already pins react@^19.2.5 and typescript@^5.9.2 and is the canonical React example exercising the bulk of @lexical/react. Verified locally that `tsc --noEmit` from the example dir exits 0 against the current published 0.44.0 packages.
markselby9
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
markselby9
changed the title
etrepum
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7093 — the follow-up to #7080: "we don't currently have a way to verify that there aren't any skipLibCheck false regressions. It would make sense to have at least one of our examples configured as such with React 19 and a newer typescript."
Sets
skipLibCheck: falseonexamples/react-rich/tsconfig.json. The example's existingtsc && vite buildstep is exercised by the integration tests inscripts/__tests__/integration/prepare-release.test.mjs(which callsdescribeExamplefor everyexamples/*), so any future@types/reactor typescript-lib regression in the published Lexical.d.tssurface will fail that build.react-richwas picked because it already pins the modern stack you specified (react@^19.2.5,typescript@^5.9.2) and is the canonical React example exercising the bulk of@lexical/react.CI surface
The integration-tests workflow runs on
after-approval.ymland ontests-extended.ymlwhen a maintainer adds theextended-testsordependencieslabel. It does not run on every PR by default (tests.ymlhaspaths-ignore: examples/**). So this is passive regression coverage that triggers post-approval / on-label, not a per-PR gate.Verification
Scope
One-line config flip in
examples/react-rich/tsconfig.json. No source / build-script / CI workflow changes. The siblingtsconfig.node.jsonis intentionally left alone — plaintsc(used bynpm run build) doesn't walk project references, so flipping it would have been dead weight.Closes #7093