[lexical][lexical-yjs][lexical-playground] Chore: Respect browserslist by levensta · Pull Request #8512 · facebook/lexical

levensta · 2026-05-14T01:23:24Z

Description

The project has added an eslint plugin that checks features against the current browserslist https://lexical.dev/docs/getting-started/supported-browsers. This will help avoid potential compatibility issues

Closes #6573

Test plan

Before

There is no rule that would automatically check the compatibility of a feature with a specific list of browsers.

After

Added eslint-plugin-compat
The lookbehind of prohibited characters in the playground has been replaced with a set of allowed characters
In lexical-yjs, Object.hasOwn has been replaced with the old safe equivalent Object.prototype.hasOwnProperty

vercel · 2026-05-14T01:23:29Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lexical	Ready	Preview, Comment	May 17, 2026 11:07pm
lexical-playground	Ready	Preview, Comment	May 17, 2026 11:07pm

levensta · 2026-05-14T01:27:24Z

+  // Compatibility with browserslist
+  {
+    ...compat.configs['flat/recommended'],
+    ignores: ['packages/lexical-playground/**'],


Do you think compatibility should be enforced in playgrounds? Theoretically, it's possible to set up checks there and disable some code. Or add a fallback for simple cases like structuredClone

> @lexical/monorepo@0.44.0 lint > eslint ./ ./packages/lexical-playground/src/plugins/AutocompletePlugin/index.tsx 93:25 error navigator.userAgentData() is not supported in Safari 15, Firefox 115, Edge 86, Chrome 86 compat/compat ./packages/lexical-playground/src/plugins/ContextMenuPlugin/index.tsx 70:38 error navigator.permissions() is not supported in Safari 15 compat/compat 99:38 error navigator.permissions() is not supported in Safari 15 compat/compat ./packages/lexical-playground/src/plugins/PagesReactExtension/PageSetupDropdown.tsx 34:14 error structuredClone is not supported in Safari 15, Edge 86, Chrome 86 compat/compat ./packages/lexical-playground/src/utils/docSerialization.ts 40:14 error CompressionStream is not supported in Safari 15 compat/compat 61:14 error DecompressionStream is not supported in Safari 15 compat/compat

It's probably best practice to keep the compat on in the playground and simply enable/disable features accordingly. It doesn't look like we have a real use case for structuredClone, a shallow {...clone} will work just as well in those two call sites. The other situations could be behind typeof guards maybe with warnOnlyOnce usage to put something in the console on very old environments

etrepum

I think the @ is missing from the negative lookbehind transformation

etrepum · 2026-05-14T03:02:04Z


 const URL_REGEX =
-  /((https?:\/\/(www\.)?)|(www\.))[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_+.~#?&//=]*)(?<![-.+():%])/;
+  /((https?:\/\/(www\.)?)|(www\.))[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b(?:[-a-zA-Z0-9()@:%_+.~#?&//=]*[a-zA-Z0-9_~#?&//=])?/;


Suggested change

/((https?:\/\/(www\.)?)|(www\.))[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b(?:[-a-zA-Z0-9()@:%_+.~#?&//=]*[a-zA-Z0-9_~#?&//=])?/;

/((https?:\/\/(www\.)?)|(www\.))[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b(?:[-a-zA-Z0-9()@:%_+.~#?&//=]*[a-zA-Z0-9@_~#?&//=])?/;

etrepum · 2026-05-17T03:14:23Z

+      it.each([true, false])(
+        'preserves indentation (CompressionStream: %s)',
+        async hasCompressionStream => {
+          if (!hasCompressionStream) {
+            vi.stubGlobal('CompressionStream', undefined);
+          }


What is the point of this? There's no CompressionStream related code anywhere in here?

etrepum · 2026-05-17T03:30:14Z

+    encoded = encodeURIComponent(json);
+    CompressionAPIWarning();


If we provide a fallback encoding it should decode correctly in implementations that do have the DecompressionStream API. Probably better to just provide a warning and do nothing.

etrepum · 2026-05-17T04:42:01Z

+    CompressionAPIWarning();
+    return JSON.parse(decodeURIComponent(b64));


This is primarily going to fail so probably not worth trying

etrepum · 2026-05-17T20:39:11Z

+  if (typeof CompressionStream !== 'undefined') {
+    const cs = new CompressionStream('gzip');
+    const writer = cs.writable.getWriter();
+    const [, output] = await Promise.all([
+      writer
+        .write(new TextEncoder().encode(JSON.stringify(doc)))
+        .then(() => writer.close()),
+      readBytestoString(cs.readable.getReader()),
+    ]);
+    return `#doc=${btoa(output)
+      .replace(/\//g, '_')
+      .replace(/\+/g, '-')
+      .replace(/=+$/, '')}`;
+  }
+
+  CompressionAPIWarning();
+  return '';


I would generally reverse the order of this, bail early if something is missing and leave the happy path with less indentation

etrepum · 2026-05-17T20:39:26Z

+  if (typeof CompressionStream !== 'undefined') {
+    const ds = new DecompressionStream('gzip');
+    const writer = ds.writable.getWriter();
+    const b64 = atob(m[1].replace(/_/g, '/').replace(/-/g, '+'));
+    const array = new Uint8Array(b64.length);
+    for (let i = 0; i < b64.length; i++) {
+      array[i] = b64.charCodeAt(i);
+    }
+    const closed = writer.write(array).then(() => writer.close());
+    const output = [];
+    for await (const chunk of generateReader(
+      ds.readable.pipeThrough(new TextDecoderStream()).getReader(),
+    )) {
+      output.push(chunk);
+    }
+    await closed;
+    return JSON.parse(output.join(''));
  }
-  await closed;
-  return JSON.parse(output.join(''));
+  CompressionAPIWarning();
+  return null;


should also re-order this

etrepum

this is what I had meant, there's no need for an else here

Co-authored-by: Bob Ippolito <bob@redivi.com>

levensta · 2026-05-17T23:22:46Z

+function getCompressionStream() {
+  if (typeof CompressionStream !== 'undefined') {
+    return new CompressionStream('gzip');
+  }
+}


skillfully!

respect browserslist

4254417

levensta requested review from acywatson, etrepum, fantactuka, ivailop7, potatowagon, takuyakanbr and zurfyx as code owners May 14, 2026 01:23

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2026

levensta commented May 14, 2026

View reviewed changes

Comment thread packages/lexical-react/src/shared/useCharacterLimit.ts

vercel Bot deployed to Preview – lexical May 14, 2026 01:24 View deployment

vercel Bot deployed to Preview – lexical-playground May 14, 2026 01:24 View deployment

levensta commented May 14, 2026

View reviewed changes

etrepum added the extended-tests Run extended e2e tests on a PR label May 14, 2026

etrepum reviewed May 14, 2026

View reviewed changes

levensta added 2 commits May 16, 2026 13:01

add fallbacks in playground

4392696

Merge remote-tracking branch 'upstream/main' into add-eslint-compat

6156182

vercel Bot deployed to Preview – lexical-playground May 16, 2026 10:02 View deployment

vercel Bot deployed to Preview – lexical May 16, 2026 10:03 View deployment

etrepum reviewed May 17, 2026

View reviewed changes

revert fallback for compressionstream

a952e34

vercel Bot deployed to Preview – lexical-playground May 17, 2026 11:47 View deployment

vercel Bot deployed to Preview – lexical May 17, 2026 11:47 View deployment

etrepum reviewed May 17, 2026

View reviewed changes

levensta added 2 commits May 18, 2026 00:07

reorder conditions

2b0ee2f

Merge branch 'main' into add-eslint-compat

cdfaaee

vercel Bot deployed to Preview – lexical-playground May 17, 2026 21:09 View deployment

vercel Bot deployed to Preview – lexical May 17, 2026 21:09 View deployment

etrepum reviewed May 17, 2026

View reviewed changes

Comment thread packages/lexical-playground/src/utils/docSerialization.ts Outdated

Comment thread packages/lexical-playground/src/utils/docSerialization.ts Outdated

Apply suggestions from code review

8856501

Co-authored-by: Bob Ippolito <bob@redivi.com>

etrepum approved these changes May 17, 2026

View reviewed changes

vercel Bot had a problem deploying to Preview – lexical-playground May 17, 2026 22:52 Failure

etrepum reviewed May 17, 2026

View reviewed changes

Comment thread packages/lexical-playground/src/utils/docSerialization.ts Outdated

Update packages/lexical-playground/src/utils/docSerialization.ts

1c6c74a

vercel Bot deployed to Preview – lexical May 17, 2026 22:54 View deployment

vercel Bot deployed to Preview – lexical-playground May 17, 2026 22:54 View deployment

etrepum added 2 commits May 17, 2026 16:06

extract feature detection

fdcd8fe

typo

fb46b18

vercel Bot deployed to Preview – lexical May 17, 2026 23:07 View deployment

vercel Bot deployed to Preview – lexical-playground May 17, 2026 23:07 View deployment

levensta commented May 17, 2026

View reviewed changes

etrepum added this pull request to the merge queue May 17, 2026

Merged via the queue into facebook:main with commit e65fcd7 May 17, 2026
42 checks passed

	/((https?:\/\/(www\.)?)\|(www\.))[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b(?:[-a-zA-Z0-9()@:%_+.~#?&//=]*[a-zA-Z0-9_~#?&//=])?/;
	/((https?:\/\/(www\.)?)\|(www\.))[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b(?:[-a-zA-Z0-9()@:%_+.~#?&//=]*[a-zA-Z0-9@_~#?&//=])?/;

		CompressionAPIWarning();
		return JSON.parse(decodeURIComponent(b64));

Conversation

levensta commented May 14, 2026

Description

Test plan

Before

After

Uh oh!

vercel Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etrepum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etrepum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented May 14, 2026 •

edited

Loading