[lexical-website] Refactor: Drop docusaurus-plugin-internaldocs-fb preset by zurfyx · Pull Request #8516 · facebook/lexical

zurfyx · 2026-05-14T15:12:06Z

Description

The lexical.dev site was using docusaurus-plugin-internaldocs-fb's preset purely as a wrapper around @docusaurus/preset-classic — none of its Meta-internal features were actually used.

Per @etrepum's question on #8509: yes, we can clean it up.

What it was costing the public site

A fetch('https://staticdocs.thefacebook.com/ping') fired on every page navigation. The host is unreachable from outside Meta corpnet, producing two net::ERR_NAME_NOT_RESOLVED errors per route change in the console (the second staticdocs.thefacebook.com/ping pair in Bug: Errors appear in the browser console immediately on lexical.dev page load #8103).
A hidden <div id="internaldocs-banner"> injected into <body> on every page.
A postMessage('page-update', '*') to window.parent on every route update.
A copy event listener pinging Meta-internal feedback.reportContentCopied.
A duplicate copy of docs/ in build/_src/ (plugin postBuild artifact).
~1.2k lines of transitive deps (react-modal, react-live, mermaid v11, node-fetch@2, docusaurus-lunr-search, etc.) in pnpm-lock.yaml.

What it was contributing to the public site

Almost nothing actually load-bearing:

docs/error.md imported OssOnly from the plugin and wrapped <ErrorCodePage/> in it. <OssOnly> is a no-op when FB_INTERNAL isn't set, so the wrapper had no effect on the public build.
src/pages/gallery.md imported FBInternOnly from the plugin… but the actual export name is FbInternalOnly, so the import resolved to undefined. The component was never rendered. Pure dead code.
No fb/*.mdx pages, no fbContent / fbInternalOnly call sites anywhere in packages/lexical-website/.
No D###### / T###### / fburl.com / pixelcloud:// references in docs that depended on the internLinks / pixelcloud remark plugins.

Migration

Replaced require.resolve('docusaurus-plugin-internaldocs-fb/docusaurus-preset') with 'classic' in docusaurus.config.ts. Dropped the staticDocsProject: 'lexical' option (preset-classic doesn't take it).
Removed the dead OssOnly import + wrapper in docs/error.md.
Removed the dead/typo'd FBInternOnly import in src/pages/gallery.md.
Dropped the dep in package.json; lockfile reflects the cleanup.
Removed packages/lexical-website/fb/sdoc-cache.json (plugin-only artifact, no longer needed).

One implementation detail worth flagging

The plugin's webpack EnvironmentPlugin was substituting process.env.FB_INTERNAL at build time, which let webpack tree-shake the dynamic imports in GalleryCards.tsx:

useEffect(() => {
  if (process.env.FB_INTERNAL) {
    import('../../../../InternGalleryCards').then(setInternGalleryCards);
    import('../../../../InternGalleryTags').then(setInternGalleryTags);
  }
}, []);

Without the substitution, webpack tries to statically resolve those imports and fails the public build (those modules don't exist in this repo).

Added a small local plugin (packages/lexical-website/plugins/webpack-fb-internal/index.js) that does the same DefinePlugin substitution. Keeps the gallery code untouched and continues to work for the internal build.

Test plan

pnpm install — lockfile drops 16 top-level + many transitive entries; no surprise additions.
pnpm --filter @lexical/website run build — succeeds cleanly. The two warnings (@huggingface/transformers import.meta, HTML minifier on /docs/api/) are pre-existing on main, unrelated to this change.
pnpm exec docusaurus serve — homepage / /docs/intro / /docs/error / /gallery all 200; search index served; <title> and content render the same.
grep staticdocs.thefacebook.com build/ returns nothing — no pings will fire from the production bundle.
grep -rE 'D[0-9]{6,}|T[0-9]{6,}|fburl\.com|pixelcloud://' packages/lexical-website/{docs,blog,src/pages} returns nothing — no auto-linkification lost.
tsc / prettier / eslint all clean (lint-staged on commit).

Out of scope (intentionally)

The other items in Bug: Errors appear in the browser console immediately on lexical.dev page load #8103 (React isSelectionWithinEditor: guard against bad nodes #418, StackBlitz MIME, preloaded-but-unused worker warnings). Different root causes, separate PRs.
mayrang's [lexical-website] Bug Fix: Drop Vercel Analytics inject and unwrap chat input from flex parent #8509 stays scoped to Vercel Analytics + flex-parent fix.

Closes

Closes part of #8103 (the staticdocs.thefacebook.com/ping pair).

…eset The lexical.dev site was using docusaurus-plugin-internaldocs-fb's preset purely as a wrapper around @docusaurus/preset-classic — none of its Meta-internal features were actually used: - The OssOnly wrapper in docs/error.md was a no-op on OSS builds. - The FBInternOnly import in src/pages/gallery.md was dead code (and typo'd — the real export is FbInternalOnly, so the import resolved to undefined and never rendered). - No fb/*.mdx pages, no fbContent / fbInternalOnly call sites. Switching to @docusaurus/preset-classic directly: - Removes the staticdocs.thefacebook.com/ping fetch fired on every page navigation (closes part of #8103 — the request fails for everyone outside Meta corpnet, producing two console errors per route change). - Drops a duplicate copy of docs/ in build/_src/ (plugin postBuild artifact). - Drops ~1.2k lines of transitive dependencies (react-modal, react-live, mermaid v11, node-fetch@2, etc.) from pnpm-lock.yaml. - Removes a hidden #internaldocs-banner element injected on every page. Webpack-side, the plugin's EnvironmentPlugin used to substitute process.env.FB_INTERNAL at build time, which let webpack tree-shake the 'internal-only' dynamic imports in GalleryCards.tsx. Replaced with a small local plugin (plugins/webpack-fb-internal) that does the same DefinePlugin substitution so the public build can drop those branches. Internal Meta verification: pulled static_docs_site_hits_30d for site=lexical on 2026-05-13 — 11 hits, 1 user. Down ~10x YoY (was 117/20). All residual traffic goes to pages that also exist on lexical.dev. No internal-only content lost. Test plan: - pnpm install — lockfile drops 16 top-level + many transitive deps. - pnpm --filter @lexical/website run build — succeeds. - pnpm exec docusaurus serve — homepage, /docs/intro, /docs/error, /gallery all 200; search index present; build output contains zero references to staticdocs.thefacebook.com. - Hand-checked gallery + error pages render the same content (the wrapped components were unconditionally rendered before). Closes part of #8103. Co-authored-by: Bob Ippolito <bob@redivi.com>

vercel · 2026-05-14T15:12:11Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lexical	Ready	Preview, Comment	May 14, 2026 3:38pm
lexical-playground	Ready	Preview, Comment	May 14, 2026 3:38pm

…ck-fb-internal plugin Removes the dynamic-import branch in GalleryCards.tsx that loaded InternGalleryCards / InternGalleryTags modules from the parent directory. Those modules don't exist in this repo — they only existed alongside the synced lexical-website tree on the internal mirror. With the internal publishing path going away, that code path has no consumers; keeping it required a webpack DefinePlugin shim purely to let webpack tree-shake the dead branch out of the public bundle. Drops both: - plugins/webpack-fb-internal/ (the shim) - The if (process.env.FB_INTERNAL) useEffect in GalleryCards.tsx - Now-unused useState / useEffect imports and intern* state in GalleryCards - The Tag re-import in GalleryCards (only TagList is used) The remaining process.env.FB_INTERNAL references in docusaurus.config.ts and sidebars.js run at Node config-load time, not in the client bundle, so they don't need substitution. ErrorCodePage.tsx's !process.env.FB_INTERNAL branch resolves to !undefined === true on the public site, which is the intended behavior — the import target is a real file in this repo. Test plan: - pnpm --filter @lexical/website run build — succeeds, same two pre-existing warnings as main (unrelated huggingface import.meta + minifier on docs/api). - pnpm exec docusaurus serve — homepage / docs/intro / docs/error / gallery all 200; gallery renders OSS plugin cards correctly. - grep InternGalleryCards build/ — no references in production bundle.

potatowagon

mariekondo

zurfyx requested review from acywatson, etrepum, fantactuka, ivailop7, potatowagon and takuyakanbr as code owners May 14, 2026 15:12

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2026

vercel Bot deployed to Preview – lexical-playground May 14, 2026 15:12 View deployment

vercel Bot deployed to Preview – lexical May 14, 2026 15:12 View deployment

zurfyx added the extended-tests Run extended e2e tests on a PR label May 14, 2026

etrepum approved these changes May 14, 2026

View reviewed changes

vercel Bot deployed to Preview – lexical-playground May 14, 2026 15:38 View deployment

vercel Bot deployed to Preview – lexical May 14, 2026 15:38 View deployment

potatowagon approved these changes May 14, 2026

View reviewed changes

etrepum added this pull request to the merge queue May 14, 2026

Merged via the queue into main with commit 0e2b347 May 14, 2026
45 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[lexical-website] Refactor: Drop docusaurus-plugin-internaldocs-fb preset#8516

[lexical-website] Refactor: Drop docusaurus-plugin-internaldocs-fb preset#8516
etrepum merged 2 commits into
mainfrom
zurfyx/drop-internaldocs-fb-plugin

zurfyx commented May 14, 2026 •

edited

Loading

Uh oh!

vercel Bot commented May 14, 2026 •

edited

Loading

Uh oh!

potatowagon left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zurfyx commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What it was costing the public site

What it was contributing to the public site

Migration

One implementation detail worth flagging

Test plan

Out of scope (intentionally)

Closes

Uh oh!

vercel Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

potatowagon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zurfyx commented May 14, 2026 •

edited

Loading

vercel Bot commented May 14, 2026 •

edited

Loading