[lexical-extension][lexical-html][lexical-utils][lexical] Chore: Migrate away from legacy flow syntax#8547
Merged
Merged
Conversation
SamChou19815
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
etrepum
approved these changes
May 22, 2026
mayrang
added a commit
to mayrang/lexical
that referenced
this pull request
May 23, 2026
… merge dropped The merge resolution that resolved conflicts via `git checkout --ours` inadvertently reverted main changes that the same files needed. - `LexicalReconciler.ts`: `$reconcileElementTerminatingLineBreak` now reads `prevLineBreak` from `slot.element.__lexicalLastChildKind` (cache) instead of calling `isLastChildLineBreakOrDecorator(prevElement, ...)` on a detached prev-state node — restores the facebook#8548 crash fix. - `LexicalDOMSlot.ts`: `setManagedLineBreak` writes the cache field that the reconciler reads — without this the field declaration was orphan. - `Lexical.js.flow`: migrates remaining `+T` / `+property` to the new `out T` / `readonly` syntax to match facebook#8547's flow migration on main.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate away from legacy flow syntax
Test plan
flowin CI