[lexical] Bug Fix: Keep selection inside single-child inline elements#8772
Open
mayrang wants to merge 2 commits into
Open
[lexical] Bug Fix: Keep selection inside single-child inline elements#8772mayrang wants to merge 2 commits into
mayrang wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolveSelectionPointOnBoundarynormalizes selection points at inline element boundaries. For inline elements that returncanInsertTextAfter() === false(likeLinkNode), it pushes the cursor outside at the right edge. When the inline element contains only a single child, offset 0 is the left edge and offset 1 is the right edge — both get normalized outward, making it impossible to place the cursor inside.This adds a
parent.getChildrenSize() !== 1guard to the right-edge normalization branch, so single-child inline elements keep the cursor inside at the right edge. Left-edge normalization (which keeps left bias) is unchanged.Closes #7551
Test plan
pnpm vitest run --project unit packages/lexical/src/__tests__/unit/LexicalSelection.test.ts— 69 tests pass