add step recorder#88
Merged
Merged
Conversation
added 2 commits
February 12, 2021 15:00
facebook-github-bot
added
the
CLA Signed
feedthejim
commented
Feb 12, 2021
| if (!isRecording) { | ||
| return; | ||
| } | ||
| if (isDeleteBackward(event)) { |
Author
There was a problem hiding this comment.
this got out of hand a bit quickly haha
Author
There was a problem hiding this comment.
I can probably clean this up.
Collaborator
There was a problem hiding this comment.
This can be done in a follow up :) this PR is awesome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2021-02-12.at.15.02.27.mov
This is a helper to help us write test more easily (+1 against regressions) and also share bugs more easily.
What it does:
Not supported (yet):
You can copy paste the generated stuff and it should generate a working test.