Move targetSdk configuration from AndroidManifest to build.gradle. Fix running Unit test from Gradle#529
Closed
colriot wants to merge 1 commit into
Closed
Move targetSdk configuration from AndroidManifest to build.gradle. Fix running Unit test from Gradle#529colriot wants to merge 1 commit into
colriot wants to merge 1 commit into
Conversation
colriot
force-pushed
the
export-D14853883
branch
from
220f3c7 to
9d2e301
Compare
colriot
added a commit
to colriot/litho
that referenced
this pull request
Apr 9, 2019
…x running Unit test from Gradle (facebook#529) Summary: Pull Request resolved: facebook#529 Gradle sync is broken, because build config doesn't support setting `minSdkVersion` and `targetSdkVersion` in AndroidManifest for a long time. We need to move these config params to `build.gradle`, but this will break our Unit test execution, because of the old Robolectric version which relies on AndroidManifest. Fix TestRunner accordingly. Closes facebook#515 Differential Revision: D14853883 fbshipit-source-id: ac0817682b785ea55612e28cd4efa8f8fd70177b
colriot
force-pushed
the
export-D14853883
branch
from
9d2e301 to
8a6dfa5
Compare
colriot
added a commit
to colriot/litho
that referenced
this pull request
Apr 9, 2019
…x running Unit test from Gradle (facebook#529) Summary: Pull Request resolved: facebook#529 Gradle sync is broken, because build config doesn't support setting `minSdkVersion` and `targetSdkVersion` in AndroidManifest for a long time. We need to move these config params to `build.gradle`, but this will break our Unit test execution, because of the old Robolectric version which relies on AndroidManifest. Fix TestRunner accordingly. Closes facebook#515 Differential Revision: D14853883 fbshipit-source-id: 4d7ae9e47e36543544ea6e5ec79c7356bb208466
colriot
force-pushed
the
export-D14853883
branch
from
8a6dfa5 to
7951554
Compare
colriot
added a commit
to colriot/litho
that referenced
this pull request
Apr 10, 2019
…x running Unit test from Gradle (facebook#529) Summary: Pull Request resolved: facebook#529 Gradle sync is broken, because build config doesn't support setting `minSdkVersion` and `targetSdkVersion` in AndroidManifest for a long time. We need to move these config params to `build.gradle`, but this will break our Unit test execution, because of the old Robolectric version which relies on AndroidManifest. Fix TestRunner accordingly. Closes facebook#515 Differential Revision: D14853883 fbshipit-source-id: 91f185e14078b71b81bdc5e8b39de2a0b8e53b70
colriot
force-pushed
the
export-D14853883
branch
from
7951554 to
21bf4a1
Compare
colriot
added a commit
to colriot/litho
that referenced
this pull request
Apr 10, 2019
…x running Unit test from Gradle (facebook#529) Summary: Pull Request resolved: facebook#529 Gradle sync is broken, because build config doesn't support setting `minSdkVersion` and `targetSdkVersion` in AndroidManifest for a long time. We need to move these config params to `build.gradle`, but this will break our Unit test execution, because of the old Robolectric version which relies on AndroidManifest. Fix TestRunner accordingly. Closes facebook#515 Differential Revision: D14853883 fbshipit-source-id: 8ae8dee85bcb8c5a1e3e0c4ee90315672c56db56
colriot
force-pushed
the
export-D14853883
branch
from
21bf4a1 to
98c93a5
Compare
colriot
added a commit
to colriot/litho
that referenced
this pull request
Apr 10, 2019
…x running Unit test from Gradle (facebook#529) Summary: Pull Request resolved: facebook#529 Gradle sync is broken, because build config doesn't support setting `minSdkVersion` and `targetSdkVersion` in AndroidManifest for a long time. We need to move these config params to `build.gradle`, but this will break our Unit test execution, because of the old Robolectric version which relies on AndroidManifest. Fix TestRunner accordingly. Closes facebook#515 Differential Revision: D14853883 fbshipit-source-id: 25ff8bb2c5488bcebcc18044444e93093dcda7f3
colriot
force-pushed
the
export-D14853883
branch
from
98c93a5 to
95c27ee
Compare
colriot
added a commit
to colriot/litho
that referenced
this pull request
Apr 10, 2019
…x running Unit test from Gradle (facebook#529) Summary: Pull Request resolved: facebook#529 Gradle sync is broken, because build config doesn't support setting `minSdkVersion` and `targetSdkVersion` in AndroidManifest for a long time. We need to move these config params to `build.gradle`, but this will break our Unit test execution, because of the old Robolectric version which relies on AndroidManifest. Fix TestRunner accordingly. Closes facebook#515 Differential Revision: D14853883 fbshipit-source-id: f0a4690ac5f18d38640694f6641c0495150c61a6
…x running Unit test from Gradle (facebook#529) Summary: Pull Request resolved: facebook#529 Gradle sync is broken, because build config doesn't support setting `minSdkVersion` and `targetSdkVersion` in AndroidManifest for a long time. We need to move these config params to `build.gradle`, but this will break our Unit test execution, because of the old Robolectric version which relies on AndroidManifest. Fix TestRunner accordingly. Closes facebook#515 Reviewed By: passy Differential Revision: D14853883 fbshipit-source-id: b695521fd8512304443891c4b1745a2f102e6422
colriot
force-pushed
the
export-D14853883
branch
from
95c27ee to
4b71356
Compare
Contributor
|
This pull request has been merged in a92018a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Gradle sync is broken, because build config doesn't support setting
minSdkVersionandtargetSdkVersioninAndroidManifest for a long time. We need to move these config params to
build.gradle, but this will break ourUnit test execution, because of the old Robolectric version which relies on AndroidManifest. Fix TestRunner
accordingly. Closes #515
Differential Revision: D14853883