Added support for GAT and GATS (Get and Touch) memcached commands.#270
Added support for GAT and GATS (Get and Touch) memcached commands.#270sergmour wants to merge 3 commits into
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Summary: This change addresses issue facebook#222: Feature Request: Support GAT & GATS (Get And Touch Commands). It follows the change in the memcached ASCII protocol as of Oct 2017: GAT and GATS (Get and Touch) commands were added to memcached ASCII protocol. * GAT/GATS commands produce same output as GET/GETS commands; * GAT/GATS commands are included in GetLike routing group and are thus routed same way as GET/GETS commands; * Touch portion of GAT/GATS commands will follow the routing logic: - For parallel routes like AllAsyncRoute-AllSyncRoute all replicas are touched; - For serial routes like Failover/MissFailover only one replica is touched. * Added basic tests for GAT/GATS commands.
…to the newest trends.
|
Thanks for working on this @sergmour! |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@andreazevedo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@andreazevedo : Thanks Andre! It'll be really helpful; we have customers waiting on that feature. |
|
@andreazevedo : Hi Andre, what's the status of this PR? Is anyone looking into it? What's the status of the internal tests/review? |
|
Sorry about that @sergmour. |
|
Hey @sergmour, I just wanted to provide some feedback. Thank you again for working on this! |
|
Thanks Andre! I definitely wouldn't mind any adjustments, thanks for this. And hopefully we'd be adding more stuff to mcrouter in the near future. |
|
This is now available on trunk! It will also be available in version 41. |
3 participants
Summary:
This change addresses issue #222: Feature Request: Support GAT & GATS (Get And Touch Commands). It follows the change in the memcached ASCII protocol as of Oct 2017: GAT and GATS (Get and Touch) commands were added to memcached ASCII protocol.