Merged
Conversation
facebook-github-bot
added
the
CLA Signed
JacksonGL
approved these changes
May 31, 2022
miinhho
added a commit
to miinhho/memlab
that referenced
this pull request
Apr 22, 2026
…rting Split fixture into concern-scoped modules (types.ts, leak.ts, fixture.ts, thin index.ts barrel). Collapse the `@memlab/playwright/test` subpath into the root entry so users import from `@memlab/playwright`. Bring package metadata in line with other memlab packages: add LICENSE, publishConfig.access=public, tsconfig extends ../../tsconfig.base.json, test-pkg runs the e2e suite, README trimmed to the house format. Fix leakSummary: ISerializedInfo is a recursive dict where retainedSize is encoded inside keys as \`\$retained-size:N\`, so reading flat \`retainedSize\`/\`name\`/\`type\` was always undefined and the auto-mode teardown message always rendered \"facebook#1: leak\". It now picks the first non-\$tabsOrder trace key as the one-line digest. isInspectorArtifact walks the full serialized trace instead of only top-level keys so DevTools/Inspector retainers appearing mid-chain are filtered too. Expose GC tuning through MemlabFixture.configure({gc: {...}}) instead of the hardcoded 6-cycle; tighten CDPLike (send returns Promise<unknown>, event handlers stay \`any\` to accept narrower Playwright/Puppeteer signatures under strict function types). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pull request was created automatically because we noticed your project was missing a Contributing file.
CONTRIBUTING files explain how a developer can contribute to the project - which you should actively encourage.
This PR was crafted with love by Facebook's Open Source Team.