Add rejectUnauthorized option to ws types#1133
Closed
motiz88 wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014312 |
Summary: X-link: facebook/react-native#41337 Changelog: [Internal] Adds a Flow definition that allows passing the [`rejectUnauthorized`](https://nodejs.org/api/tls.html#tlscreateserveroptions-secureconnectionlistener:~:text=(120%20seconds).-,rejectUnauthorized,-%3Cboolean%3E%20If) option to a WebSocket client. (See [example usage](https://github.com/websockets/ws/blob/a049674d936746c36fe928cc1baaaafd3029a83e/examples/ssl.js#L33) in the `ws` repo.) Reviewed By: robhogan Differential Revision: D51014312
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/metro#1133 Changelog: [Internal] Adds a Flow definition that allows passing the [`rejectUnauthorized`](https://nodejs.org/api/tls.html#tlscreateserveroptions-secureconnectionlistener:~:text=(120%20seconds).-,rejectUnauthorized,-%3Cboolean%3E%20If) option to a WebSocket client. (See [example usage](https://github.com/websockets/ws/blob/a049674d936746c36fe928cc1baaaafd3029a83e/examples/ssl.js#L33) in the `ws` repo.) Reviewed By: robhogan Differential Revision: D51014312
motiz88
force-pushed
the
export-D51014312
branch
from
eb515d2 to
5aee931
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51014312 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
=======================================
Coverage 83.09% 83.09%
=======================================
Files 206 206
Lines 10547 10547
Branches 2617 2617
=======================================
Hits 8764 8764
Misses 1783 1783 ☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request has been merged in 187aa2c. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 6, 2023
Summary: Pull Request resolved: #41337 X-link: facebook/metro#1133 Changelog: [Internal] Adds a Flow definition that allows passing the [`rejectUnauthorized`](https://nodejs.org/api/tls.html#tlscreateserveroptions-secureconnectionlistener:~:text=(120%20seconds).-,rejectUnauthorized,-%3Cboolean%3E%20If) option to a WebSocket client. (See [example usage](https://github.com/websockets/ws/blob/a049674d936746c36fe928cc1baaaafd3029a83e/examples/ssl.js#L33) in the `ws` repo.) Reviewed By: robhogan Differential Revision: D51014312 fbshipit-source-id: 25794b1867ca5f15fab1592e8f80cdad8cdf897a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Adds a Flow definition that allows passing the
rejectUnauthorizedoption to a WebSocket client. (See example usage in thewsrepo.)Differential Revision: D51014312