Bug#34776172 MacOS: silence deprecated use warnings from XCode >= 14 #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We have much use of sprintf, which is now flagged by clang as unsafe. Silence this, since we have too many uses to rewrite easily. - This version if Xcode also flags loss of precision from 64 to 32 bits integer, silence this also. Typically when x of type size_t is assigned to an int. Change-Id: I3e5f829c7fdb8ddb08c56149bc0db1a5dc277f34
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 10, 2023
…1306) Summary: - We have much use of sprintf, which is now flagged by clang as unsafe. Silence this, since we have too many uses to rewrite easily. - This version if Xcode also flags loss of precision from 64 to 32 bits integer, silence this also. Typically when x of type size_t is assigned to an int. Change-Id: I3e5f829c7fdb8ddb08c56149bc0db1a5dc277f34 Pull Request resolved: #1306 Reviewed By: hermanlee Differential Revision: D45658644 Pulled By: sunshine-Chun fbshipit-source-id: e5fc7b3
luqun
pushed a commit
to luqun/mysql-5.6
that referenced
this pull request
Jun 5, 2023
…rom XCode >= 14 Summary: - We have much use of sprintf, which is now flagged by clang as unsafe. Silence this, since we have too many uses to rewrite easily. - This version if Xcode also flags loss of precision from 64 to 32 bits integer, silence this also. Typically when x of type size_t is assigned to an int. Change-Id: I3e5f829c7fdb8ddb08c56149bc0db1a5dc277f34 Pull Request resolved: facebook#1306 GitHub Author: Dag Wanvik <dag.wanvik@oracle.com> Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: herman Reviewed By: herman Subscribers: webscalesql-eng@fb.com Differential Revision: https://phabricator.intern.facebook.com/D45658644 Tags: accept2ship
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have much use of sprintf, which is now flagged by clang as unsafe. Silence this, since we have too many uses to rewrite easily.
This version if Xcode also flags loss of precision from 64 to 32 bits integer, silence this also. Typically when x of type size_t is assigned to an int.
Change-Id: I3e5f829c7fdb8ddb08c56149bc0db1a5dc277f34