visualization stream preview #366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
Added new stream preview feature to visualization (appears for both normal and proxy nodes).
- preview shows up in popover UI
- popover only closes when user clicks on the hide stream preview button.
- The characters for preview is limited
- scroll bar will appear if preview is too long.
- Old cbor files without stream preview still works as stream preview button only appears if stream preview is defined
Differential Revision: D91596594
jlee303
force-pushed
the
export-D91596594
branch
from
90e0d56 to
a24d49b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added new stream preview feature to visualization (appears for both normal and proxy nodes).
Differential Revision: D91596594