add a cmake 3.20.2 build test#423
Closed
Cyan4973 wants to merge 6 commits into
Closed
Conversation
Cyan4973
force-pushed
the
ci_ga_cmake_3_22
branch
from
fbb2fcc to
1a7554e
Compare
Contributor
Author
Cyan4973
force-pushed
the
ci_ga_cmake_3_22
branch
from
ccb133d to
4e3aade
Compare
Contributor
Author
|
Well, the test is still failing after #282, |
Contributor
Author
|
And with the additional fix, it now works fine on |
Cyan4973
force-pushed
the
ci_ga_cmake_3_22
branch
from
9f5541f to
323b57b
Compare
to detect issues such as facebook#282
OVERRIDE_FIND_PACKAGE (CMake 3.24+) redirects find_package() calls to FetchContent, useful when multiple subdirectories independently call find_package(googletest). In this project, no other CMakeLists.txt does that — targets from FetchContent_MakeAvailable are used directly. So both OVERRIDE_FIND_PACKAGE and its corresponding find_package call were unnecessary, and broke configure on CMake < 3.24.
The cmake 3.22 job only needs to verify build system compatibility, not re-run the full test suite which is already covered by the default cmake job.
…e minimum required version specified in CMakeLists.txt) instead of 3.22.6 to ensure backward compatibility with older cmake versions. Test Plan: Workflow syntax is valid. The change will be tested when the workflow runs in CI.
Cyan4973
force-pushed
the
ci_ga_cmake_3_22
branch
from
59eec6d to
89fcd8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new test is designed to detect issues like #282
In the process, it was discovered that #282 was not enough to fix compatibility issues,
so this PR bundles an additional
cmakefix.