Handle missing repetition/definition levels#717
Closed
daniellerozenblit wants to merge 1 commit into
Closed
Conversation
Summary: Per the parquet spec, definition/repetition level blocks are omitted from data pages when the column has no `OPTIONAL`/`REPEATED` ancestor. We did not previously handle this case, causing parsing of Parquet files with required columns to fail. This diff adds tracking of `hasDefinitionLevels` / `hasRepetitionLevels` per leaf in the schema metadata, and consume the repetition/definition blocks independently in the lexer only when present. Differential Revision: D103245483
|
@daniellerozenblit has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103245483. |
|
This pull request has been merged in 1f1a45f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Per the parquet spec, definition/repetition level blocks are omitted from data pages when the column has no
OPTIONAL/REPEATEDancestor. We did not previously handle this case, causing parsing of Parquet files with required columns to fail.This diff adds tracking of
hasDefinitionLevels/hasRepetitionLevelsper leaf in the schema metadata, and consume the repetition/definition blocks independently in the lexer only when present.Differential Revision: D103245483