Fix fuzzer input generation issues (#720)#720
Closed
terrelln wants to merge 1 commit into
Closed
Conversation
|
@terrelln has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103685305. |
Summary: Fuzzers were failing because we were consuming too much data after the end of the input. This was for two reasons: 1. Many fuzzers use more than 1 byte of entropy for each byte of input data produced. So divide `num_remaining_bytes()` by 4. 2. Some components, namely `MuxLengths`, was treating `maxInputSize` as a number of elements, rather than a number of bytes. Fix that. 3. Claude also found two other components `SentinelByte` and `CompressSmallLengths` that had the same issue, so proactively fix it. Differential Revision: D103685305
meta-codesync
Bot
changed the title
terrelln
force-pushed
the
export-D103685305
branch
from
df9506a to
bbf2191
Compare
|
This pull request has been merged in e87029e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fuzzers were failing because we were consuming too much data after the end of the input. This was for two reasons:
num_remaining_bytes()by 4.MuxLengths, was treatingmaxInputSizeas a number of elements, rather than a number of bytes. Fix that.SentinelByteandCompressSmallLengthsthat had the same issue, so proactively fix it.Differential Revision: D103685305