Introduce SDDL2 Result types#725
Closed
daniellerozenblit wants to merge 1 commit into
Closed
Conversation
Summary: Replace out-parameter error handling with Result types that bundle values with error codes. This prevents bugs from uninitialized outputs and uses ZL_NODISCARD to catch ignored errors at compile time. New SDDL2_RESULT_OF(type) macro creates Result structs with accessor macros (SDDL2_isError, SDDL2_error, SDDL2_value) and constructors (SDDL2_success, SDDL2_failure). API changes: - SDDL2_kind_size(), SDDL2_Type_size() now return SDDL2_RESULT_OF(size_t) - SDDL2_Stack_pop() now returns SDDL2_RESULT_OF(SDDL2_Value) - Internal pop_* helpers now return Result types - Added SDDL2_TRY_LET for concise error propagation Updated all call sites in sddl2.c, sddl2_vm.c, and tests. Reviewed By: Cyan4973 Differential Revision: D103698980
|
@daniellerozenblit has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103698980. |
|
This pull request has been merged in 7e19db3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace out-parameter error handling with Result types that bundle values with error codes. This prevents bugs from uninitialized outputs and uses ZL_NODISCARD to catch ignored errors at compile time.
New SDDL2_RESULT_OF(type) macro creates Result structs with accessor macros (SDDL2_isError, SDDL2_error, SDDL2_value) and constructors (SDDL2_success, SDDL2_failure).
API changes:
Updated all call sites in sddl2.c, sddl2_vm.c, and tests.
Reviewed By: Cyan4973
Differential Revision: D103698980