Reorganize SDDL examples into sddl/ and sddl2/ directories#726
Closed
daniellerozenblit wants to merge 1 commit into
Closed
Reorganize SDDL examples into sddl/ and sddl2/ directories#726daniellerozenblit wants to merge 1 commit into
daniellerozenblit wants to merge 1 commit into
Conversation
Summary: Separate SAO example files by SDDL language version: SDDL1 examples live in `examples/sddl/`, and SDDL2 examples live in `examples/sddl2/`. Also adds an SDDL1-syntax port of the SAO parser. ### Changes - Move `sao_full.sddl` and `sao_silesia.sddl` from `examples/sddl/` to `examples/sddl2/` (these are SDDL2 sources) - Add `examples/sddl/sao_full.oldv1.sddl`: an SDDL1 implementation of the SAO star catalog parser Reviewed By: Cyan4973 Differential Revision: D103718414
|
@daniellerozenblit has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103718414. |
|
This pull request has been merged in 4918a3b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Separate SAO example files by SDDL language version: SDDL1 examples live in
examples/sddl/, and SDDL2 examples live inexamples/sddl2/.Also adds an SDDL1-syntax port of the SAO parser.
Changes
sao_full.sddlandsao_silesia.sddlfromexamples/sddl/toexamples/sddl2/(these are SDDL2 sources)examples/sddl/sao_full.oldv1.sddl: an SDDL1 implementation of the SAO star catalog parserReviewed By: Cyan4973
Differential Revision: D103718414