Fix xgboost MinGW build issue (#727)#727
Closed
jlee303 wants to merge 1 commit into
Closed
Conversation
|
@jlee303 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103741888. |
meta-codesync
Bot
changed the title
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
May 5, 2026
Summary: Fix `make -j1` build on MSYS2/MinGW by specifying the "Unix Makefiles" CMake generator (otherwise CMake may pick Ninja or NMake on Windows) Reviewed By: Cyan4973 Differential Revision: D103741888
Summary: Fix `make -j1` build on MSYS2/MinGW by specifying the "Unix Makefiles" CMake generator (otherwise CMake may pick Ninja or NMake on Windows) Reviewed By: Cyan4973 Differential Revision: D103741888
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
May 5, 2026
Summary: Fix `make -j1` build on MSYS2/MinGW by specifying the "Unix Makefiles" CMake generator (otherwise CMake may pick Ninja or NMake on Windows) Reviewed By: Cyan4973 Differential Revision: D103741888
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
May 5, 2026
Summary: Fix `make -j1` build on MSYS2/MinGW by specifying the "Unix Makefiles" CMake generator (otherwise CMake may pick Ninja or NMake on Windows) Reviewed By: Cyan4973 Differential Revision: D103741888
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
May 5, 2026
Summary: Fix `make -j1` build on MSYS2/MinGW by specifying the "Unix Makefiles" CMake generator (otherwise CMake may pick Ninja or NMake on Windows) Reviewed By: Cyan4973 Differential Revision: D103741888
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
May 5, 2026
Summary: Fix `make -j1` build on MSYS2/MinGW by specifying the "Unix Makefiles" CMake generator (otherwise CMake may pick Ninja or NMake on Windows) Reviewed By: Cyan4973 Differential Revision: D103741888
|
This pull request has been merged in da8f054. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix
make -j1build on MSYS2/MinGW by specifying the "Unix Makefiles" CMake generator (otherwise CMake may pick Ninja or NMake on Windows)Reviewed By: Cyan4973
Differential Revision: D103741888