Fix flaky ParquetChunkedTest.test_chunk_size_affects_output#736
Closed
Cyan4973 wants to merge 1 commit into
Closed
Fix flaky ParquetChunkedTest.test_chunk_size_affects_output#736Cyan4973 wants to merge 1 commit into
Cyan4973 wants to merge 1 commit into
Conversation
Summary: The test checks that two trained compressors with different chunk sizes produce different `.zlc` files. The previous version compared file sizes, but `ACE` training is non-deterministic, and two runs can produce different artifacts but with identical size, which trips the assertion as a false positive. This is rare but can happen in CI, making CI signal flaky. Switch to a bytewise comparison, which must always be true. Differential Revision: D103963402
|
@Cyan4973 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103963402. |
|
This pull request has been merged in c6eb178. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The test checks that two trained compressors with different chunk sizes produce different
.zlcfiles.The previous version compared file sizes, but
ACEtraining is non-deterministic, and two runs can produce different artifacts but with identical size, which trips the assertion as a false positive. This is rare but can happen in CI, making CI signal flaky.Switch to a bytewise comparison, which must always be true.
Differential Revision: D103963402