Skip to content

events: removing newline from windows event log lines#3985

Merged
muffins merged 1 commit into
osquery:masterfrom
muffins:win-events-newline-fix
Dec 5, 2017
Merged

events: removing newline from windows event log lines#3985
muffins merged 1 commit into
osquery:masterfrom
muffins:win-events-newline-fix

Conversation

@muffins

@muffins muffins commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

This cleans up the trailing newline in the windows_events table to ensure sanity of data formatting.

@muffins muffins added events Related to osquery's evented tables or eventing subsystem virtual tables Windows labels Dec 4, 2017
@facebook-github-bot facebook-github-bot added the cla signed Automated label: Pull Request author has signed the osquery CLA label Dec 4, 2017
@osqueryer

Copy link
Copy Markdown

👎 The commit 7c926d4 (Job results: 3151) failed one or more tests (Windows).

@osqueryer

Copy link
Copy Markdown

👎 The commit 7c926d4 (Job results: 3153) failed one or more tests (Windows).

@muffins

muffins commented Dec 4, 2017

Copy link
Copy Markdown
Contributor Author

ok to test

@osqueryer

Copy link
Copy Markdown

👎 The commit 7c926d4 (Job results: 3155) failed one or more tests (Windows).

@osqueryer

Copy link
Copy Markdown

👎 The commit 7c926d4 (Job results: 3156) failed one or more tests (Windows).

@muffins

muffins commented Dec 5, 2017

Copy link
Copy Markdown
Contributor Author

Looks like something is borked with Windows tests :( Will investigate.

@theopolis

Copy link
Copy Markdown
Member

You may be seeing another form of the flaky test_retrieve_config test: #3246

@muffins

muffins commented Dec 5, 2017

Copy link
Copy Markdown
Contributor Author

ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Automated label: Pull Request author has signed the osquery CLA events Related to osquery's evented tables or eventing subsystem virtual tables Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants