Skip to content

Comments

Update setup.py#2027

Merged
tcuongd merged 3 commits intofacebook:masterfrom
anukaal:master
Oct 3, 2021
Merged

Update setup.py#2027
tcuongd merged 3 commits intofacebook:masterfrom
anukaal:master

Conversation

@anukaal
Copy link
Contributor

@anukaal anukaal commented Sep 15, 2021

updated classifiers

updated classifiers
@facebook-github-bot
Copy link
Contributor

Hi @anukaal!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@tcuongd tcuongd self-requested a review October 3, 2021 01:05
Copy link
Collaborator

@tcuongd tcuongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I've just removed the Python 3.9 classifier for now since pystan 2.19.1.1 is not available for Python 3.9. We will eventually remove pystan altogether and use cmdstanpy instead (which will enable us to build wheels for python 3.9), that will probably come with the next release.

@tcuongd
Copy link
Collaborator

tcuongd commented Oct 3, 2021

Checks are failing (my fault), we'll just need to merge with master once this PR is in: #2040 then it should be all good.

@anukaal
Copy link
Contributor Author

anukaal commented Oct 3, 2021

Checks are failing (my fault), we'll just need to merge with master once this PR is in: #2040 then it should be all good.

Yeah it would be fine ig !

@tcuongd tcuongd merged commit 675ece7 into facebook:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants