Rather using Monday const from built-in calendar.py

[Gordonei]

Latest version of python-holidays (0.9.9) changed the name of its MONDAY const to MON. Rather using the MONDAY const from the same library as the object that it is being used with (calendar module).

Also, given this constant is 19 years old (!), I suspect it might not change in the near future.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[ivonnics]

Hi!
I just installed Prophet, however, when I type:
from fbprophet import Prophet
I got this error:
ImportError: cannot import name 'MONDAY'
I ran: pip install fbprophet --upgrade before asking the question, and even with that I got the same error.
I can not even execute:
import fbprophet
fbprophet.__version__
As I get the same ImportError: cannot import name 'MONDAY'...
I believe this error is related to Gordonei`s comment, so any suggestion on how to overcome this error, would be extremelly welcome...

[Gordonei]

Hey @ivonnics , @louisguitton suggested a work around in the issue that he opened.

[bletham]

This is great, thanks so much for the fix.

[bletham]

An especially good fix because it works with both old and new versions of holidays.

[Gordonei]

☺️ Doing a bit of Git archeology, I think the authors of `holidays` might have lifted it from the `calendar` module. To be honest, I also felt a bit responsible, as I recently made a change to holidays (not the `MONDAY` one, though) that might have prompted this release.

[bletham]

heh, well all is well that ends well :-)